Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not normalize name when uploading #2057

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix: do not normalize name when uploading #2057

merged 2 commits into from
Jun 27, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8724567) 84.76% compared to head (6142633) 84.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files          99       99              
  Lines        9455     9454       -1     
  Branches     2065     2065              
==========================================
- Hits         8015     8014       -1     
  Misses        990      990              
  Partials      450      450              
Flag Coverage Δ
unittests 84.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/publish/package.py 75.93% <ø> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming marked this pull request as ready for review June 27, 2023 01:22
@frostming frostming merged commit c4f4a68 into main Jun 27, 2023
@frostming frostming deleted the fix/upload branch June 27, 2023 01:23
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants