Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install --plugins cannot install self package #2062

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (51c6ccb) 84.56% compared to head (4dc6eff) 84.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
+ Coverage   84.56%   84.63%   +0.07%     
==========================================
  Files         100      100              
  Lines        9607     9612       +5     
  Branches     2101     2103       +2     
==========================================
+ Hits         8124     8135      +11     
+ Misses       1028     1022       -6     
  Partials      455      455              
Flag Coverage Δ
unittests 84.41% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/installers/core.py 100.00% <ø> (ø)
src/pdm/cli/commands/install.py 89.36% <100.00%> (+0.23%) ⬆️
src/pdm/cli/templates/__init__.py 88.13% <100.00%> (+0.20%) ⬆️
src/pdm/installers/synchronizers.py 85.66% <100.00%> (+0.78%) ⬆️
src/pdm/resolver/core.py 92.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit ffd1af4 into main Jun 28, 2023
@frostming frostming deleted the fix/install-self branch June 28, 2023 06:44
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants