Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter wrong package meta information and duplicate path #2076

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

vvanglro
Copy link
Contributor

@vvanglro vvanglro commented Jul 3, 2023

This PR fix #2075 .

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: -0.02 ⚠️

Comparison is base (ffd1af4) 84.55% compared to head (275d957) 84.53%.

❗ Current head 275d957 differs from pull request most recent head 342c1d2. Consider uploading reports for the commit 342c1d2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
- Coverage   84.55%   84.53%   -0.02%     
==========================================
  Files         100      100              
  Lines        9612     9626      +14     
  Branches     2103     2106       +3     
==========================================
+ Hits         8127     8137      +10     
- Misses       1029     1033       +4     
  Partials      456      456              
Flag Coverage Δ
unittests 84.31% <70.58%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/templates/__init__.py 85.24% <0.00%> (-2.89%) ⬇️
src/pdm/models/caches.py 88.42% <100.00%> (+0.56%) ⬆️
src/pdm/models/working_set.py 65.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming
Copy link
Collaborator

frostming commented Jul 3, 2023

Please add a news fragment into news/ folder, you can look at CONTRIBUTING.md for how to.

@vvanglro
Copy link
Contributor Author

vvanglro commented Jul 3, 2023

Please add a news fragment into news/ folder, you can look at CONTRIBUTING.md for how to.

Done.

@frostming frostming merged commit b001b96 into pdm-project:main Jul 3, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm sync TypeError: expected string or bytes-like object, got 'NoneType'
3 participants