Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid mistakenly passing command-line arguments while testing #2084

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: avoid mistakenly passing command-line arguments while testing #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2083.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid mistakenly passing command-line arguments while testing.
7 changes: 4 additions & 3 deletions src/pdm/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ def main(
) -> None:
"""The main entry function"""

# Ensure same behavior while testing and using the CLI
args = self._get_cli_args(args or sys.argv[1:], obj)
if args is None:
args = []
args = self._get_cli_args(args, obj)
# Keep it for after project parsing to check if its a defined script
root_script = None
try:
Expand Down Expand Up @@ -287,4 +288,4 @@ def my_plugin(core: pdm.core.Core) -> None:

def main(args: list[str] | None = None) -> None:
"""The CLI entry function"""
return Core().main(args)
return Core().main(args or sys.argv[1:])