Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't overwrite lockfile when locking in pdm install #2090

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: don't overwrite lockfile when locking in pdm install #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a1aa16
fix: don't overwrite lockfile when locking in `pdm install`
frostming Jul 7, 2023
4a319ce
fix
frostming Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2086.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug that lockfile groups are overwritten when running locking in a preceding step of `pdm install`.
10 changes: 8 additions & 2 deletions src/pdm/cli/commands/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,15 @@ def handle(self, project: Project, options: argparse.Namespace) -> None:
sys.exit(1)
if options.lock:
project.core.ui.echo("Updating the lock file...", style="success", err=True)

unseleted = GroupSelection(project)
actions.do_lock(
project, strategy=strategy, dry_run=options.dry_run, hooks=hooks, groups=selection.all()
project,
strategy=strategy,
dry_run=options.dry_run,
hooks=hooks,
# We would like to keep the selected groups when the lockfile exists
# but use the groups passed-in when creating a new lockfile.
groups=unseleted.all() if strategy != "all" else selection.all(),
)

actions.do_sync(
Expand Down