Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the comparison of candidate keys #2123

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

frostming
Copy link
Collaborator

Fixes #2120

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #2120

Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (279edb4) 84.45% compared to head (f61418e) 84.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2123   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files         100      100           
  Lines        9711     9713    +2     
  Branches     2135     2136    +1     
=======================================
+ Hits         8201     8203    +2     
  Misses       1044     1044           
  Partials      466      466           
Flag Coverage Δ
unittests 84.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/repositories.py 72.25% <100.00%> (-0.09%) ⬇️
src/pdm/resolver/providers.py 92.71% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 546a367 into main Jul 22, 2023
@frostming frostming deleted the frostming/issue2120 branch July 22, 2023 07:45
@apoorvkh
Copy link

@frostming Would you consider creating a minor version release that includes this fix? Thank you!

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when running pdm install
3 participants