-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comparable_version() #2182
Fix comparable_version() #2182
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 100 100
Lines 9786 9787 +1
Branches 2161 2161
=======================================
+ Hits 8247 8248 +1
Misses 1065 1065
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Note: I am currently forking Please feel free to provide any guidance or insights if necessary. Thank you very much for your support and assistance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fragment in news/
directory is required
@frostming The file is added. Please review again, thanks. |
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
This will complete the attribute editing procedure.
It makes
comarable_version("1.2.3+local1") == Version("1.2.3")
which is not achievable now.