Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparable_version() #2182

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

drunkwcodes
Copy link
Contributor

@drunkwcodes drunkwcodes commented Aug 14, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

This will complete the attribute editing procedure.
It makes comarable_version("1.2.3+local1") == Version("1.2.3") which is not achievable now.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (79a56a7) 84.27% compared to head (a324a42) 84.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2182   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         100      100           
  Lines        9786     9787    +1     
  Branches     2161     2161           
=======================================
+ Hits         8247     8248    +1     
  Misses       1065     1065           
  Partials      474      474           
Flag Coverage Δ
unittests 84.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pdm/utils.py 84.76% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drunkwcodes
Copy link
Contributor Author

Note: I am currently forking pdm to cater to the needs of the Mojo language, and the resulting project will be named mojo-muse. I appreciate your work in developing this well-established architecture and software.

Please feel free to provide any guidance or insights if necessary. Thank you very much for your support and assistance!

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fragment in news/ directory is required

@drunkwcodes
Copy link
Contributor Author

@frostming The file is added. Please review again, thanks.

@frostming frostming merged commit 31a2e2f into pdm-project:main Aug 17, 2023
18 checks passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants