Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update comparison with hatch in README #2210

Merged
merged 1 commit into from
Aug 29, 2023
Merged

doc: Update comparison with hatch in README #2210

merged 1 commit into from
Aug 29, 2023

Conversation

doolio
Copy link
Contributor

@doolio doolio commented Aug 29, 2023

Closes #2204.

Pull Request Checklist

- [ ] A news fragment is added in news/ describing what is new.
- [ ] Test cases added for changed code.

Describe what you have changed in this PR.

Update to README.

@frostming frostming merged commit 7fd3f43 into pdm-project:main Aug 29, 2023
@@ -66,7 +66,7 @@ instead using a custom `[tool.poetry]` table. This is partly because Poetry came

### [Hatch](https://hatch.pypa.io)

Hatch can also manage environments (it allows multiple environments per project, but it does not allow to put them in the project directory), and it can manage packages (but without lockfile support). Hatch can also be used to package a project (with PEP 621-compliant pyproject.toml files) and upload it to PyPI.
Hatch can also manage environments, allowing multiple environments per project. By default it has a central location for all environments but it can be configured to put a project's environment(s) in the project root directory. It can manage packages but without lockfile support. It can also be used to package a project (with PEP 621/631-compliant pyproject.toml files) and upload it to PyPI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Hatch can also manage environments, allowing multiple environments per project. By default it has a central location for all environments but it can be configured to put a project's environment(s) in the project root directory. It can manage packages but without lockfile support. It can also be used to package a project (with PEP 621/631-compliant pyproject.toml files) and upload it to PyPI.
Hatch can also manage environments, allowing multiple environments per project. By default it has a central location for all environments but it can be configured to put a project's environment(s) in the project root directory. It can manage packages but without lockfile support. It can also be used to package a project (with PEP 621-compliant pyproject.toml files) and upload it to PyPI.

From the PEP itself:

This PEP has been accepted and was merged into PEP 621.

So I don't think 631 should be listed here 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I thought it was the other way round and 621 was merged into 631.

@pawamoy
Copy link
Contributor

pawamoy commented Aug 29, 2023

Ha, @frostming too fast! 😅

@doolio doolio deleted the update-readme branch August 29, 2023 10:02
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README out of date wrt to comparison with hatch.
3 participants