Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't reset the build backend when asking for import #2393

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: Don't reset the build backend when asking for import #2393

merged 1 commit into from
Nov 10, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2388

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@frostming
fix: Don't reset the build backend when asking for import
184e2ed 
Fixes #2388

Signed-off-by: Frost Ming <me@frostming.com>
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pdm/cli/actions.py 79.00% <0.00%> (ø)
src/pdm/cli/commands/import_cmd.py 61.22% <50.00%> (-1.28%) ⬇️

📢 Thoughts on this report? Let us know!

@frostming frostming merged commit 3ea9a23 into main Nov 10, 2023
22 of 24 checks passed
@frostming frostming deleted the frostming/issue2388 branch November 10, 2023 08:35
@j178 j178 mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ask_for_import() resets build backend to default
1 participant
@frostming