Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default verbosity level in UI.echo docstring #2460

Merged

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented Dec 2, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

UI.echo docstring default verobsity level was wrong. it was changed in #2304
However, I am bit skeptical: shouldn't the default level be NORMAL?

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba703d1) 84.55% compared to head (ef94ae2) 84.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2460   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         104      104           
  Lines       10280    10280           
  Branches     2247     2247           
=======================================
  Hits         8692     8692           
  Misses       1114     1114           
  Partials      474      474           
Flag Coverage Δ
unittests 84.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming
Copy link
Collaborator

frostming commented Dec 2, 2023

However, I am bit skeptical: shouldn't the default level be NORMAL?

Default to NORMAL means it can be suppressed by --quiet, but there are many information-only commands whose only effect is to print something to the console(consider pdm config and pdm list for examples). If the default value is QUIET, which means to always show, we don't need to bother passing the level explicitly.

@frostming frostming merged commit d3c3e4d into pdm-project:main Dec 2, 2023
21 checks passed
@deronnax
Copy link
Contributor Author

deronnax commented Dec 2, 2023

OK, legit. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants