Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates instructions for private repositories in pdm publish. #2569

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

rentruewang
Copy link
Contributor

@rentruewang rentruewang commented Jan 17, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

I have updated docs s.t. the github actions workflow example in the Build and Publish page would work for private repositories.

The reason it would previously not work is because settings of

permissions:
      id-token: write

would overwrite the default which is

permissions:
      contents: read

which results in a checkout fail.

See: actions/checkout#254 (not the issue itself, but the explanation here actions/checkout#254 (comment))

@frostming frostming merged commit b95c31a into pdm-project:main Jan 18, 2024
1 check passed
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants