Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pdm export -f requirements exports package twice #3126

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: pdm export -f requirements exports package twice #3126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3123.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug of export command that packages with extras are included twice.
5 changes: 4 additions & 1 deletion src/pdm/cli/commands/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ def handle(self, project: Project, options: argparse.Namespace) -> None:
raise PdmUsageError(
"Can't export a lock file without environment markers, please re-generate the lock file with `inherit_metadata` strategy."
)
candidates = [entry.candidate for entry in project.get_locked_repository().packages.values()]
candidates = sorted(
(entry.candidate for entry in project.get_locked_repository().packages.values()),
key=lambda c: not c.req.extras,
)
groups = set(selection)
packages = []
seen_extras: set[str] = set()
Expand Down
Loading