Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --dev --group test ignores dev if empty group with that name already exists in optional-dependencies #3136

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #3133

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

…name already exists in optional-dependencies

Fixes #3133

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (7d52cfd) to head (97cecb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
+ Coverage   85.65%   85.70%   +0.05%     
==========================================
  Files         109      109              
  Lines       11032    11037       +5     
  Branches     2408     2411       +3     
==========================================
+ Hits         9449     9459      +10     
+ Misses       1092     1088       -4     
+ Partials      491      490       -1     
Flag Coverage Δ
unittests 85.50% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 7cb963d into main Aug 30, 2024
24 checks passed
@frostming frostming deleted the frostming/issue3133 branch August 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --dev --group test ignores dev if empty group with that name already exists in optional-dependencies
1 participant