Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inherit_metadata would be written in lock file if the file is not pdm.lock even strategy config is true #3236

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #3232

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

…t pdm.lock even strategy config is true

Fixes #3232

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (4401ff5) to head (4937eaf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/project/core.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   85.42%   85.42%   -0.01%     
==========================================
  Files         112      112              
  Lines       11323    11318       -5     
  Branches     2459     2457       -2     
==========================================
- Hits         9673     9668       -5     
  Misses       1125     1125              
  Partials      525      525              
Flag Coverage Δ
unittests 85.21% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit d954e79 into main Oct 31, 2024
22 of 24 checks passed
@frostming frostming deleted the frostming/issue3232 branch October 31, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] inherit_metadata would be written in lock file if the file is not pdm.lock even strategy config is true
1 participant