Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file prefix (-fp) wont work with "-f original" #29

Closed
telemaxx opened this issue Mar 24, 2020 · 2 comments
Closed

file prefix (-fp) wont work with "-f original" #29

telemaxx opened this issue Mar 24, 2020 · 2 comments

Comments

@telemaxx
Copy link
Contributor

telemaxx commented Mar 24, 2020

fit_filename is not really used.
fit_filename = directory + '/' + prefix + 'activity_' + activity_id + append_desc + '.fit'
with -f gpx it is ok.
i will fix that with the next PR for workflow mode

pe-st added a commit that referenced this issue Mar 29, 2020
@pe-st
Copy link
Owner

pe-st commented Mar 29, 2020

Thanks for spotting that one.

fit_filename is only used to check if the file was already download. But this check only works for .fit files (original files can also be the very old Garmin .tcx format or manually uploaded .gpx files)

Only when downloading the zip and unzipping it you can know the real extension of the original file.

This was an easy enough error to fix, so I corrected it on my p3 branch...

@telemaxx
Copy link
Contributor Author

telemaxx commented Apr 2, 2020

fixed in latest p3 branch

@telemaxx telemaxx closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants