Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 and Python2 with latest changes from feature/p3 #27

Merged
merged 18 commits into from
Mar 21, 2020

Conversation

telemaxx
Copy link
Contributor

python3 -> feature/p3

from os.path import sep
can only do a handfull test until garmin blocks me for some time
some work with: def write_to_file(filename, content, mode, file_time=None):
otherwise gpx are not handled correctly
... when using gpx
gpx content are not always str hmmm
by more inteligent imports.
This reverts commit 7f5ff09.
a lot lot doubled code in "def http_req()"
@telemaxx
Copy link
Contributor Author

new try of python3 integration with solved conflicts. #PR26 is closed.
some discussion you find here:
#26

@telemaxx
Copy link
Contributor Author

telemaxx commented Mar 21, 2020

Tests done:

P3: fitfiles with unzip
c:\Python3\python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 10 -f original --username "myname" --password "mypasswd" --directory "C:\public\gps" --unzip

P3: gpx files
c:\Python3\python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f gpx --username "myname" --password "mypasswd" --directory "C:\public\gps"

P3: tcx files
c:\Python3\python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f tcx --username "myname" --password "mypasswd" --directory "C:\public\gps"

P3: gpx files in subfolder
c:\Python3\python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f gpx --username "myname" --password "mypasswd" --directory "C:\public\gps" -s gpx

P3: tcx files in subfolder
c:\Python3\python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f tcx --username "myname" --password "mypasswd" --directory "C:\public\gps" -s tcx

P3: this makes is also working now, due the changes of peter?
c:\Python3\Python.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 12 -f tcx --username "myname" --password "mypasswd"--directory "C:\public\gps" --unzip --desc 12 -fp -sa 8 -s tcx

P2: fitfiles with unzip
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 10 -f original --username "myname" --password "mypasswd" --directory "C:\public\gps" --unzip

P2: gpx files
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 10 -f gpx --username "myname" --password "mypasswd" --directory "C:\public\gps"

P2: tcx files with some options
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 10 -f tcx --username "myname" --password "mypasswd" --directory "C:\public\gps" --unzip --desc 12 -fp -sa 8 -s tcx

P2: gpx files in subfolder
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f gpx --username "myname" --password "mypasswd" --directory "C:\public\gps" -s gpx

P2: tcx files in subfolder
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 5 -f tcx --username "myname" --password "mypasswd" --directory "C:\public\gps" -s tcx

P2: tcx file in subfolder with many options
c:\Pypy2\pypy.exe C:\Users\top\BTSync\SA5\qpython\scripts\Garmin-Connect-Export-pest\gcexport.py -c 12 -f tcx --username "myname" --password "mypasswd"--directory "C:\public\gps" --unzip --desc 12 -fp -sa 8 -s tcx

@pe-st pe-st merged commit 1745129 into pe-st:feature/p3 Mar 21, 2020
@pe-st
Copy link
Owner

pe-st commented Mar 21, 2020

Thanks @telemaxx ! This should already be usable for many users.

There are some remaining issues (e.g. two broken unit tests with Python 3, option -c all not working yet), but I hope to fix them in the next couple of days.

Once these issues have been sorted out I should be able to merge it on the main develop branch and release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants