Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_files creates subdir instead of overwriting contents of same-name dir #509

Closed
quite opened this issue Oct 10, 2020 · 6 comments
Closed
Assignees
Labels
bug Something isn't working resolved

Comments

@quite
Copy link

quite commented Oct 10, 2020

I'm using this action here, with keep_files: true (currently set to false) https://github.com/fruktkartan/fruktkartan/blob/master/.github/workflows/deploy-production.yml#L24

I'm quite confident that the latest v3 deploys js/file to js/js/file, when the js directory already exists (same for fonts etc).

@quite quite added the bug Something isn't working label Oct 10, 2020
@quite
Copy link
Author

quite commented Oct 10, 2020

I'm setting keep_files: false for now (currently don't need it).

@peaceiris
Copy link
Owner

peaceiris commented Oct 10, 2020

Thanks.

Duplicate of #507 and related to #324 (I will keep this issue to track this problem.)

peaceiris added a commit that referenced this issue Oct 11, 2020
Note that users who are using a Static Site Generator do not need this option in most cases. Please reconsider your project structure and building scripts, or use a built-in feature of a Static Site Generator before you enable this flag.

- [Static Files | Hugo](https://gohugo.io/content-management/static-files/)
- [Using the Static Folder | Gatsby](https://www.gatsbyjs.com/docs/static-folder/)

Related issues:

- #507
- #509
@peaceiris peaceiris mentioned this issue Oct 11, 2020
1 task
@peaceiris
Copy link
Owner

peaceiris commented Oct 11, 2020

@hathawayj @quite

Could you test #512 as follows?

- name: Deploy
  uses: peaceiris/actions-gh-pages@f9a2c29 #512
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    keep_files: true

@hathawayj
Copy link

I modified my main.yml action with the above settings and then pushed a new markdown file for projects and everything seem to build correctly. Thanks for the fix.

@peaceiris
Copy link
Owner

@peaceiris peaceiris mentioned this issue Oct 15, 2020
1 task
peaceiris added a commit that referenced this issue Oct 15, 2020
Close #520

Related to:

- pr: #512 
- #507 #509 
- #390
- #324
- #103
peaceiris pushed a commit that referenced this issue Oct 15, 2020
Close #520

Related to:

- pr: #512
- #507 #509
- #390
- #324
- #103
@github-actions
Copy link
Contributor

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolved
Projects
None yet
Development

No branches or pull requests

3 participants