-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: drop ubuntu-18.04, add 22.04, latest #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! ʕ◔ϖ◔ʔ
Codecov ReportBase: 61.45% // Head: 61.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 61.45% 61.45%
=======================================
Files 4 4
Lines 275 275
Branches 45 45
=======================================
Hits 169 169
Misses 105 105
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@peaceiris Dev image step broke( I will look into this. |
@peaceiris Dev image build should be fixed now. |
@peaceiris Sorry. It turns out it works with |
@peaceiris Hi. Just wanted to ask if you have any feedback for this PR? If you are currently busy or do not have time to look into this, that is ok, this is not urgent. I know that opensource maintenance could be very taxing. |
Could you revert the changes to the .nvmrc and Dockerfile? I will work on bumping the node version in my task. |
467a217
to
f3c33ff
Compare
@peaceiris Done. Rolled back all changes to |
Also, if you give me directions on what your plan is I could pick up your PR for node upgrade. I assume it is this one #539. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. 👍
This PR was made as a part of blog post The strongest principle of the blog's growth lies in the human choice to deploy it