Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove extra try-catch #30

Merged
merged 2 commits into from
Jan 3, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 30 additions & 34 deletions src/installer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,42 +17,38 @@ if (!tempDir) {
}

export default async function installer(version: string) {
try {
const osName: string = getOS(process.platform);
console.log(`Operating System: ${osName}`);
const osName: string = getOS(process.platform);
console.log(`Operating System: ${osName}`);

const mdbookURL: string = getURL(osName, version);
core.debug(`mdbookURL: ${mdbookURL}`);
const toolURL: string = getURL(osName, version);
core.debug(`toolURL: ${toolURL}`);

let baseLocation: string;
if (process.platform === 'win32') {
baseLocation = process.env['USERPROFILE'] || 'C:\\';
} else {
baseLocation = `${process.env.HOME}`;
}
const mdbookPath: string = path.join(baseLocation, 'mdbookbin');
await io.mkdirP(mdbookPath);
core.addPath(mdbookPath);
let baseLocation: string;
if (process.platform === 'win32') {
baseLocation = process.env['USERPROFILE'] || 'C:\\';
} else {
baseLocation = `${process.env.HOME}`;
}
const toolPath: string = path.join(baseLocation, 'toolbin');
await io.mkdirP(toolPath);
core.addPath(toolPath);

// Download and extract mdbook binary
await io.mkdirP(tempDir);
const mdbookAssets: string = await tc.downloadTool(mdbookURL);
let mdbookBin: string = '';
if (osName === 'pc-windows-msvc') {
const mdbookExtractedFolder: string = await tc.extractZip(
mdbookAssets,
tempDir
);
mdbookBin = `${mdbookExtractedFolder}/mdbook.exe`;
} else {
const mdbookExtractedFolder: string = await tc.extractTar(
mdbookAssets,
tempDir
);
mdbookBin = `${mdbookExtractedFolder}/mdbook`;
}
await io.mv(mdbookBin, mdbookPath);
} catch (error) {
core.setFailed(error.message);
// Download and extract mdbook binary
await io.mkdirP(tempDir);
const toolAssets: string = await tc.downloadTool(toolURL);
let toolBin: string = '';
if (osName === 'pc-windows-msvc') {
const toolExtractedFolder: string = await tc.extractZip(
toolAssets,
tempDir
);
toolBin = `${toolExtractedFolder}/mdbook.exe`;
} else {
const toolExtractedFolder: string = await tc.extractTar(
toolAssets,
tempDir
);
toolBin = `${toolExtractedFolder}/mdbook`;
}
await io.mv(toolBin, toolPath);
}