-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD dax module #13
ADD dax module #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just some comments about it being generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, check for the other suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just few readme file updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some good comments from @shubhamPeak . rest looks good
Description
Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.
This PR adds a dax module to the already present terraform modules.
Review Checks
Please check if the PR fulfills these requirements:
Put an
x
in the boxes that apply, Remove any lines that do not applyDependencies
Add links to any pull requests or documentation related to this pull request.
None
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Security Considerations
Are there any other security or data concerns to be aware of?
Please discuss the security implications/considerations relevant to the proposed change.
This may include...
All security considerations in place.
Types of change
What kind of change does this Pull Request introduce?
Put an
x
in the boxes that applyTesting
Please include steps that the reviewer can follow in order to test the changes