feat: add security group IDs to DAX module #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.
This PR aims to add the capability to attach existing Security Groups when creating a DAX cluster. Currently, the default Security Group is attached to the DAX cluster when putting it in a VPC.
I have also done a little house-keeping by
.dccache
to the.gitignore
fileREADME.md
file to include the updated usageReview Checks
Please check if the PR fulfills these requirements:
Put an
x
in the boxes that apply, Remove any lines that do not applyDependencies
Add links to any pull requests or documentation related to this pull request.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
The users of this module would need to pass the Security Group IDs from now on. The existing users would not be affected.
Security Considerations
Are there any other security or data concerns to be aware of?
Please discuss the security implications/considerations relevant to the proposed change.
This may include...
Types of change
What kind of change does this Pull Request introduce?
Put an
x
in the boxes that applyIf "Other" please specify
Testing
Please include steps that the reviewer can follow in order to test the changes
git::https://github.com/Pancham97/terraform-modules.git//tags?ref=feat-add-security-group-to-dax
terraform init
terraform plan