Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log level and stats #359

Closed
bartek-siudeja opened this issue Sep 22, 2021 · 1 comment · Fixed by #451
Closed

log level and stats #359

bartek-siudeja opened this issue Sep 22, 2021 · 1 comment · Fixed by #451
Assignees
@kucukaslan @boraberke
Labels
good first issue
Milestone
v2.0.0

Comments

@bartek-siudeja
Copy link

Is it possible to prevent s5cmd cp from listing all copied files while still keeping --stat output? It seems that --log error is the only way to prevent s5cmd from listing files. Yet this also prevents --stat from working, as it is attached to info logging level. I have to copy thousands of files, and listing everything is too busy, so getting some kind of stats at the end would be nice. I don't think it would be unreasonable for --stat to force output independent of log level, since this is what user is asking for.
@igungor
Copy link
Member

igungor commented Sep 24, 2021 •
edited
Loading

I think it's doable. --stat output should have no "level". If it is given, the output should be printed regardless of the log level.

If we do this, we must target for version 2. We can't break version 1 compatibility.

@ilkinulas ilkinulas added this to the v2.0.0 milestone Jun 27, 2022
@ilkinulas ilkinulas mentioned this issue Jun 28, 2022
Closed
boraberke added a commit to boraberke/s5cmd that referenced this issue Jun 28, 2022
@boraberke @kucukaslan
flag/stat: fix omitted stat in error log level
fe77a41 
Create unit & e2e tests
Fixes peak#359

Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
@boraberke boraberke mentioned this issue Jun 28, 2022
Merged
@igungor igungor added this to s5cmd Jun 29, 2022
@igungor igungor moved this to In Progress in s5cmd Jun 29, 2022
@igungor igungor modified the milestones: v2.0.0, v2.1.0 Jun 29, 2022
boraberke added a commit that referenced this issue Jul 1, 2022
@boraberke @kucukaslan
flag/stat: fix omitted stat in error log level (#451)
35bb2fa 
* flag/stat: fix omitted stat in error log level

Create unit & e2e tests
Fixes #359

Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>

* use keys explicitly in composite literal

Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>

* Update CHANGELOG.md

Co-Authored-By: Muhammed Can Küçükaslan <32893303+MuhammedCanKucukaslan@users.noreply.github.com>

* log: remove reduntant tests

Removed unit tests in log_test.go as they are already tested in TestAppDashStat under e2e/app_test.go

Removed redundant integration test which is already covered by another test in the same file.

Co-Authored-By: Muhammed Can Küçükaslan <32893303+MuhammedCanKucukaslan@users.noreply.github.com>

Co-authored-by: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
Repository owner moved this from In Progress to Done in s5cmd Jul 1, 2022
boraberke added a commit to boraberke/s5cmd that referenced this issue Jul 4, 2022
@boraberke @kucukaslan
flag/stat: fix omitted stat in error log level
568ad61 
Create unit & e2e tests
Fixes peak#359

Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
boraberke added a commit to boraberke/s5cmd that referenced this issue Jul 5, 2022
@boraberke @kucukaslan
flag/stat: fix omitted stat in error log level
ca3fd47 
Create unit & e2e tests
Fixes peak#359

Co-Authored-By: Muhammed Can Küçükaslan <32893303+muhammedcankucukaslan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kucukaslan kucukaslan

@boraberke boraberke

Labels
good first issue
Projects
s5cmd
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

flag/stat: fix omitted stat in error log level boraberke/s5cmd
5 participants
@igungor @ilkinulas @bartek-siudeja @kucukaslan @boraberke