storage: unknown url format #449
Comments
|
Also related to #352. |
boraberke
added a commit
to boraberke/s5cmd
that referenced
this issue
Jul 5, 2022
This commit allows url with adjacent slashes to be handled correctly.
- Disabled RestProtocolURICleaning (link) as it do not allow adjacent slashes.
- Changed path.Join method to strings.Join when joined remote urls. path.Join also cleans paths which removes additional slashes.
- Kept local urls to be joined with path.Join.
- Added test cases for copy;
- Remote to local
- Local to remote
- Remote to remote
- Removed redundant trailing slashes in the keys of s3 objects in ls_test.go and sync_test.go files.
Fixes: peak#352 ,peak#449
igungor
pushed a commit
that referenced
this issue
Jul 22, 2022
This commit allows url with adjacent slashes to be handled correctly.
- Disabled RestProtocolURICleaning (link) as it do not allow adjacent slashes.
- Changed path.Join method to strings.Join when joined remote urls. path.Join also cleans paths which removes additional slashes.
- Kept local urls to be joined with path.Join.
- Added test cases for copy;
- Remote to local
- Local to remote
- Remote to remote
- Removed redundant trailing slashes in the keys of s3 objects in ls_test.go and sync_test.go files.
Fixes #352
Fixes #449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
works:
aws s3 ls s3://foo/bar/s3://bazfails:
s5cmd ls s3://foo/bar/s3://bazstorage: unknown url format
(keys like these should be legal)
The text was updated successfully, but these errors were encountered: