disable aws sdk logger if log level is not "trace" #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kucukaslan
requested review from
aykutfarsak and
ilkinulas
and removed request for
a team
Currently, we request aws-sdk's logs regardless of s5cmd's log level, then we either use or discard those logs depending on the log level. This commit disables aws-sdk logs (unless log level is "trace") instead of discarding the logs after they created. So, it will reduce the memory/CPU usage when other log levels used, since those unneeded logs won't be created at all.
ilkinulas
approved these changes
Jul 5, 2022
igungor
reviewed
Jul 7, 2022
igungor
reviewed
Jul 7, 2022
aykutfarsak
approved these changes
Jul 7, 2022
igungor
reviewed
Jul 7, 2022
AWS logs should be written only if log level is trace, not unless.
igungor
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we request aws-sdk's logs regardless of s5cmd's log level, then we either use or discard those logs depending on the log level.
This commit disables aws-sdk logs (unless log level is "trace") instead of discarding the logs after they created.
So, it will reduce the memory/CPU usage when other log levels used, since those unneeded logs won't be created at all.