Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer and PEAR manifests don't match #6

Closed
wants to merge 1 commit into from
Closed

Composer and PEAR manifests don't match #6

wants to merge 1 commit into from

Conversation

mbabker
Copy link

@mbabker mbabker commented Sep 2, 2016

The declared minimum supported PHP version doesn't match in the Composer and PEAR manifests. Corrected Composer to match PEAR.

The declared minimum supported PHP version doesn't match in the Composer and PEAR manifests.  Corrected Composer to match PEAR.
@csthomas
Copy link

csthomas commented Sep 2, 2016

There is some inconsistency:

https://github.com/pear/Cache_Lite/blob/master/package.xml#L34-L39

<notes>
 - Add PHP5-style constructors, but keep PHP4 ones for BC
 - Make non-static test method static
 - Raise minimum PEAR version to 1.10.1
 - Raise minimum PHP version to 5.4

Mininum PHP 5.4 but support old constructors?

@cweiske
Copy link
Member

cweiske commented Sep 2, 2016

Read http://cweiske.de/tagebuch/php4-constructors-php7.htm for an explanation.

@csthomas
Copy link

csthomas commented Sep 2, 2016

OK.

@csthomas
Copy link

csthomas commented Sep 3, 2016

If I can ask you @cweiske to release one another version 1.7.17 (which supported php5.3) with the same changes in code as in 1.8.0 (means new constructors).

@photodude
Copy link

@csthomas I tried to have the last update be compatible with PHP 5.3, Here is the response #5 (comment)

so we have PHP 5.4 minimum due to PEAR dependency/api listed as 1.10.1

@mbabker mbabker closed this Sep 27, 2017
@mbabker mbabker deleted the patch-1 branch September 27, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants