Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8 compatibility issues #84

Merged
merged 26 commits into from
Feb 7, 2019
Merged

Fix PHP 8 compatibility issues #84

merged 26 commits into from
Feb 7, 2019

Commits on Feb 7, 2019

  1. Remove $vars argument from error handler

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    35be713 View commit details
    Browse the repository at this point in the history

  2. Remove track_errors=1 ini option 

    This is no longer available in PHP 8, and generates an error on
startup.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    446bda9 View commit details
    Browse the repository at this point in the history

  3. Replace continue in switch with break 

    break and "continue 2" are the same in this case and the code mixes
both. I'm using break here for simplicity.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    de70ed8 View commit details
    Browse the repository at this point in the history

  4. Make test_PEAR_Dependency2::singleton() method static 

    Because it is called statically
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    47d80e3 View commit details
    Browse the repository at this point in the history

  5. Remove /e flag in preg_match_all 

    This flag hasn't been supported since PHP 7, but more importantly
it doesn't even apply to preg_match_all in the first place.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    2af2980 View commit details
    Browse the repository at this point in the history

  6. Make PEAR_Common::betterStates() static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    bf07026 View commit details
    Browse the repository at this point in the history

  7. Remove use of create_function in PEAR Registry

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    72d3c6f View commit details
    Browse the repository at this point in the history

  8. Make PEAR_Dependency2::normalizeDep() static 

    Also adjust one call to it, though this is not strictly necessary.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    1488617 View commit details
    Browse the repository at this point in the history

  9. Also make PEAR_Dependency2::signOperator() static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    550c0a6 View commit details
    Browse the repository at this point in the history

  10. Make PEAR_Dependency2::_getExtraString() static 

    Also make calls to it static (not strictly necessary) and drop an
object instantiation that becomes unnecessary due to that.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    585246e View commit details
    Browse the repository at this point in the history

  11. Remove create_function() use in PEAR_Downloader

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    b8d5595 View commit details
    Browse the repository at this point in the history

  12. Call method on instance in test

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    5aa5e9c View commit details
    Browse the repository at this point in the history

  13. Make PEAR_ErrorStack::staticPop() static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    87896ef View commit details
    Browse the repository at this point in the history

  14. Remove uses of create_function in PackageFile_v2

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    3b7d55b View commit details
    Browse the repository at this point in the history

  15. Remove create_function use in Command_Registry

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    b3db06d View commit details
    Browse the repository at this point in the history

  16. Remove create_function() use in phpt_test

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    7cf175f View commit details
    Browse the repository at this point in the history

  17. Make PEAR_Config::_prependPath() static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    553b7a2 View commit details
    Browse the repository at this point in the history

  18. Remove error handler $vars in test

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    8c5f6ae View commit details
    Browse the repository at this point in the history

  19. Make some test methods static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    ac4abec View commit details
    Browse the repository at this point in the history

  20. Migrate PEAR_Installer away from $php_errormsg

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    7a8ac62 View commit details
    Browse the repository at this point in the history

  21. Migrate PEAR_Downloader away from php_errormsg

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    9d48b4c View commit details
    Browse the repository at this point in the history

  22. Make fakeHandleError() method in test static

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    793f0f8 View commit details
    Browse the repository at this point in the history

  23. Switch fake_log to use __construct

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    5d4ffa0 View commit details
    Browse the repository at this point in the history

  24. Make PEAR_Common::analyzeSourceCode() static 

    There are many non-static uses of that one, which I'm not touching.
They aren't a problem.
    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    d9916ac View commit details
    Browse the repository at this point in the history

  25. Don't use create_function() in tests

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    eb357e4 View commit details
    Browse the repository at this point in the history

  26. Mark some functions as static in tests

    @nikic
    nikic committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    25061ef View commit details
    Browse the repository at this point in the history