fix endianness issue, close bug, py3: bytes/str, imports #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses a few niggling issues I've had with pylibtiff, esp in the py3 context. Also in here is a bugfix (close could sometimes throw an exception) and to report endianness differences in the numpy array dtype. |
pearu
requested changes
Feb 3, 2020
| 'bitarray-a1646c0')) | ||
| import bitarray as _bitarray # noqa: F402 | ||
| _sys.modules['libtiff.bitarray'] = _bitarray | ||
| _bitarray = _os.path.join(_os.path.dirname(__file__), 'bitarray-a1646c0') |
There was a problem hiding this comment.
Use _bitarray_dir instead of _bitarray.
| @@ -519,7 +519,7 @@ def open(cls, filename, mode='r'): | |||
| return tiff | |||
|
|
|||
| @staticmethod | |||
| def get_numpy_type(bits, sample_format=None): | |||
| def get_numpy_type(bits, sample_format=None, byte_swapped=False): | |||
There was a problem hiding this comment.
Would it make sense to use self.IsByteSwapped() as a default value to byte_swapped?
If so, then eliminate byte_swapped argument?
|
Fixes issue #108 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.