Skip to content

Commit

Permalink
Address some feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
hellcp committed May 31, 2021
1 parent a65a43f commit 55084a4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions lib/ui/home/tabs/locker_tab.dart
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
);
}

Card facesCard(App face, bool compatible) {
Card _facesCard(App face, bool compatible) {
return Card(
key: ValueKey(face.uuid),
child: Container(
Expand Down Expand Up @@ -296,7 +296,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
);
}

Widget appsItem(App app, bool compatible) {
Widget _appsItem(App app, bool compatible) {
return Container(
key: ValueKey(app.uuid),
height: 72.0,
Expand Down Expand Up @@ -368,7 +368,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
),
delegate: SliverChildListDelegate(
compatibleFaces
.map<Widget>((face) => facesCard(face, true))
.map<Widget>((face) => _facesCard(face, true))
.toList(),
),
),
Expand Down Expand Up @@ -396,7 +396,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
),
delegate: SliverChildListDelegate(
incompatibleFaces
.map<Widget>((face) => facesCard(face, false))
.map<Widget>((face) => _facesCard(face, false))
.toList(),
),
),
Expand All @@ -407,7 +407,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
slivers: [
SliverReorderableList(
itemBuilder: (BuildContext context, int index) {
return appsItem(compatibleApps[index], true);
return _appsItem(compatibleApps[index], true);
},
itemCount: compatibleApps.length,
onReorder: (int fromIndex, int toIndex) {
Expand Down Expand Up @@ -441,7 +441,7 @@ class LockerTab extends HookWidget implements CobbleScreen {
SliverList(
delegate: SliverChildListDelegate(
incompatibleApps
.map<Widget>((app) => appsItem(app, false))
.map<Widget>((app) => _appsItem(app, false))
.toList(),
),
),
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/theme/cobble_theme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class CobbleTheme {
),
labelPadding: EdgeInsets.only(top: 5, bottom: 4),
unselectedLabelColor: scheme.muted,
// Indicator should be rounded and not straight, implement that later
// TODO: Indicator should be rounded and not straight, implement that later
indicator: UnderlineTabIndicator(
borderSide: BorderSide(
width: 4.0,
Expand Down

0 comments on commit 55084a4

Please sign in to comment.