Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contribute link to footer #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

clay53
Copy link

@clay53 clay53 commented Aug 4, 2019

No description provided.

@KonradIT
Copy link
Member

KonradIT commented Aug 4, 2019

hmmm, do fix this:

hmmmm

@clay53 clay53 reopened this Aug 4, 2019
@clay53
Copy link
Author

clay53 commented Aug 4, 2019

Uh... I think I fixed it? I've never done a pull request before. I had updated the packages - apparently forgetting that that wasn't the goal of the change. Then, I tried to revert it with a commit - and didn't do it correctly. I'm hoping that a hard reset doesn't cause any problems but now it's saying +0 and -0 so I'm not sure.

@sGerli
Copy link
Member

sGerli commented Aug 9, 2019

Looks good to me, but we should wait until we get a contributor guide.
@ishotjr is going to something like that.
When that's done just change the link and I'll merge it.

@@ -4,7 +4,7 @@
Rebble Store&nbsp;<small>for&nbsp;pebble</small>
</div>
<div class="main">
<p>© {{ new Date().getFullYear() }} Rebble · <a v-on:click="openExternal($store.state.contactLink)">Contact Us</a> · <a v-on:click="openExternal($store.state.tosLink)">Terms</a></p>
<p>© {{ new Date().getFullYear() }} Rebble · <a v-on:click="openExternal($store.state.contactLink)">Contact Us</a> · <a v-on:click="openExternal($store.state.tosLink)">Terms</a> · <a v-on:click="openExternal('https://github.com/pebble-dev/rebble-store')">Contribute</a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change link to contributor guide when it gets published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants