Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbitmap_is_palette_black_and_white is only available on BASALT #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nothingmn
Copy link

No description provided.

@Meiguro
Copy link

Meiguro commented Jun 8, 2015

Hmm, this appears to break builds on aplite since the function is unconditionally used in aplite.

In fact, aplite always returns GBitmapFormat1Bit for gbitmap_get_format, so gbitmap_is_palette_black_and_white is always safely false in aplite, since aplite gbitmaps, while they are black and white images, do not have palettes to consider as black and white.

I agree that it is a little odd that aplite seemingly has palette modification code, but it is compiled away as deadcode since it is guarded. I may consider refactoring it if it is too confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants