Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos #85

Open
export-mike opened this issue May 12, 2016 · 0 comments
Open

Videos #85

export-mike opened this issue May 12, 2016 · 0 comments

Comments

@export-mike
Copy link
Member

How can we load up videos in a more declarative way?

At the moment, we have markdown for page content. then use IDS in divs etc to determine what video to place in the given element. this requires code to be added for every video we have on the site.

We could improve this by having something like:

markdown file

  video-url: 'path/to/video.mp4'
  mobile-video-gif: 'path/to/image.gif'

corresponding handlebars template would have:

<div data-video-url="{videoUrl}" data-video-mobile-gif="{mobileVideoUrl}"> 
</div>

thoughts suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant