-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 44kHz WT and option for max voices #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 44kHz WT is found at https://github.com/pedrolcl/sonivox/blob/0c7beb23c2da2f2b8d3aa7c7bf126b50c53e46f9/arm-wt-22k/jetcreator_lib_src/darwin-x86/wt_44khz.c.
And should remain there. There is no need to make a copy.
I think it weird that the 44k one has the same samples as the 22k one, only articulations and regions are different. How it works? 😕
wt_22khz.c
has both 8 bits and 16 bits samples conditioned by the symbol _8_BIT_SAMPLES
, whilewt_44khz.c
has only 8 bit samples.
Tests are broken, and I do not know how to work on it.
The test suite uses the sample rate as an argument. It only needed a small change to fix the tests.
Anyway, this branch has lower quality results than the default, which uses 16 bits samples. The sample rate has less impact on the overall quality. Instead of using a different embedded soundfont, a better solution is to use an external DLS.
You asked about how it works. The name Here is an alternate PR using the other soundfont |
|
Then, you should re-add your file, commit and push it. |
This reverts commit 2aed483.
This works with both sample rates 22050 and 44100. I still don't like having, in the same repository, two large source files that are mostly identical. What about unifying them into a single one? We could rename the unified source as: "wt_200k_g.c", which was the original file name according to one top comment. By the way, you can find the original soundfont "wt_200k_G.sf2" in this archive. |
I just split the WTs and merged the same parts together. It should look better now. |
Thanks for your work! |
The 44kHz WT is found at https://github.com/pedrolcl/sonivox/blob/0c7beb23c2da2f2b8d3aa7c7bf126b50c53e46f9/arm-wt-22k/jetcreator_lib_src/darwin-x86/wt_44khz.c.
I think it weird that the 44k one has the same samples as the 22k one, only articulations and regions are different. How it works? 😕
Tests are broken, and I do not know how to work on it.