Support configuration cache #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid using project during task execution. Add extra parameters instead. * Don't use BuildType as parameter. Use directly buildTypeName as parameter instead.
pedrovgs
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
🎩 What is the goal?
Support Gradle configuration cache.
How is it being implemented?
How can it be tested?
Ideally, I could enable configuration cache in
shot-consumerproject, but this requires to update AGP and Gradle.Should I do the update? Do you prefer that I do it as current PR or as separate PR?I see that there is a pending PR with an update. #288Disclaimer
I don't know Scala. All changes were done just by following current code. Please keep that in mind during code review.
PS. BTW, having Kotlin as programming language would enable much more people to contribute.