Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot name to test report #294

Merged

Conversation

TomSenier
Copy link
Contributor

In the case of a screenshot test taking multiple screenshots per test it would be useful to have the name of the screenshot displayed in the test report. This PR adds this small change.

Copy link

@nathan-may nathan-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrovgs pedrovgs closed this Apr 23, 2022
@pedrovgs pedrovgs reopened this Apr 23, 2022
Copy link
Owner

@pedrovgs pedrovgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TomSenier can you please check code formatting? CI reports there is an error I'm sure you can automatically fix by running a grade task the project provides 😃 Thank you in advance!

@pedrovgs
Copy link
Owner

I fixed code formatting for you 😃. As soon as the build passes, I'll merge this PR. Thanks!

@pedrovgs
Copy link
Owner

I updated the code formatting for you, once the build passes, I'll merge this PR. Thanks!

@pedrovgs pedrovgs merged commit 2d50bd5 into pedrovgs:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants