Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tolerance docs and fix bug in tolerance comparison #303

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Update tolerance docs and fix bug in tolerance comparison #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f8ecc
Update README.md
pedrovgs Apr 23, 2022
9503a7c
Make tolerance inclusive and fail only tests if the % of changes is b…
pedrovgs Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ shot {
}
```

If you configure ``tolerance = 1`` it means the tolerance threshold will be 100% and all your tests will pass even if they should fail...so be careful when configuring this param.
If you configure ``tolerance = 100`` it means the tolerance threshold will be 100% and all your tests will pass even if they should fail...so be careful when configuring this param.

Take into account the ``instrumentationTestTask`` could be different if you use different flavors or build types. Remember also you should use Shot > 3.0.0 because this feature was introduced in this release!

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsComparator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class ScreenshotsComparator {
val percentageOfDifferentPixels =
differentPixels.length.toDouble / oldScreenshotPixels.length.toDouble
val percentageOutOf100 = percentageOfDifferentPixels * 100.0
val imagesAreDifferent = percentageOutOf100 >= tolerance
val imagesAreDifferent = percentageOutOf100 > tolerance
val imagesAreConsideredEquals = !imagesAreDifferent
if (imagesAreConsideredEquals && tolerance != Config.defaultTolerance) {
val screenshotName = screenshot.name
Expand Down