Bump version to 3.10 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedugnat
reviewed
Aug 9, 2022
.github/workflows/build.yml
Outdated
| @@ -7,7 +7,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.9"] | |||
| python-version: ["3.8", "3.9", "3.10"] | |||
There was a problem hiding this comment.
I guess the major thing with current PR is that python-version will only be ["3.10"] and not ["3.8", "3.9", "3.10"] no ? A lot of new features are not backward compatible (cf. CI)
There was a problem hiding this comment.
It would be best if we only supported 3.10 yes but I wanted to make sure that was ok with you before scrapping 3.8 altogether
pedugnat
added a commit
that referenced
this pull request
Aug 11, 2022
This reverts commit f460921. modifié : .github/workflows/build.yml modifié : .gitignore modifié : .pre-commit-config.yaml modifié : cookiecutter-config-file.yml modifié : dynnode2vec/biased_random_walk.py modifié : dynnode2vec/dynnode2vec.py modifié : dynnode2vec/utils.py modifié : poetry.lock modifié : pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading python version to 3.10 (now that StellarGraph is gone 🎉)