Improve the performance of * and / operators #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current implementation of the multiplicative arithmetic operators is naive, as it converts the
minorUnits
into a Decimal representation, applies the artihmetic, then does a conversion back to
minorUnits
.This can be improved with conversions to both Double, and by doing the arithmetic directly.
Modifications:
Result:
Performing multiplicative arithmetic against currencies should be much faster now. (XCTest
measure
reports 50% improvement)