Change XXX.minorUnits to 0
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: ISO 4217 leaves the 'minorUnits' or 'exponent' of several currencies as 'undefined'. For example, both XTS and XXX have no specified value. XTS was given the value of '1' arbitrarily for the purposes of testing rounding behaviors, while XXX should be 0 as "no currency" is used in transactions with XXX. Modification: - Change: `XXX.minorUnits` to be `0` Result: `XXX` currency values should now be whole number representations.
|
Code Climate has analyzed commit 598ffb4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 6 6
Lines 489 489
=======================================
Hits 471 471
Misses 18 18Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ISO 4217 leaves the 'minorUnits' or 'exponent' of several currencies as 'undefined'. For example, both XTS and XXX have no specified value.
XTS was given the value of '1' arbitrarily for the purposes of testing rounding behaviors, while XXX should be 0 as "no currency" is used
in transactions with XXX.
Modification:
XXX.minorUnitsto be0Result:
XXXcurrency values should now be whole number representations.