Improve currency localization ergonomics #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: String interpolation is powerful, but the syntax is not particularly discoverable as there is no code completion assistance, at least in Xcode. In addition, the parameter labels don't match the Swift API Design Guidelines. Modifications: - Add: `localizedString(for:nilDescription:)` to `AnyCurrency` that uses the String interpolation implementation - Add: `localizedString(using:nilDescription:)` to `AnyCurrency` that uses the String interpolation implementation - Change: `(localize:withFormatter:nilDescription:)` to `(localize:with:nilDescription:)` - Change: `(localize:forLocale:nilDescription:)` to `(localize:for:nilDescription:)` Result: Developers should have an easier time discovering the localization capabilities of currencies much easier, with more options for generating localized strings.
|
Code Climate has analyzed commit 3a63bfa and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 89.65% 89.88% +0.23%
==========================================
Files 6 6
Lines 174 178 +4
==========================================
+ Hits 156 160 +4
Misses 18 18 Continue to review full report at Codecov.
|
Mordil
added
semver-minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
String interpolation is powerful, but the syntax is not particularly discoverable as there is no code completion assistance, at least in Xcode.
In addition, the parameter labels don't match the Swift API Design Guidelines.
Modifications:
localizedString(for:nilDescription:)toAnyCurrencythat uses the String interpolation implementationlocalizedString(using:nilDescription:)toAnyCurrencythat uses the String interpolation implementation(localize:withFormatter:nilDescription:)to(localize:with:nilDescription:)(localize:forLocale:nilDescription:)to(localize:for:nilDescription:)Result:
Developers should have an easier time discovering the localization capabilities of currencies much easier, with more options for generating localized strings.