Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect for indentation #77

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Respect for indentation #77

merged 1 commit into from
Oct 3, 2018

Conversation

nathanchapman
Copy link
Contributor

Respects the user's indentation in their package.json

Fixes #68

@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #77 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   97.88%   97.88%   +<.01%     
==========================================
  Files          35       35              
  Lines         708      709       +1     
  Branches      138      139       +1     
==========================================
+ Hits          693      694       +1     
  Misses         15       15
Impacted Files Coverage Δ
src/tasks/updatePackageJson.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff56fbb...aed1964. Read the comment docs.

Copy link
Member

@jhnns jhnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good 👍
Even with tests 😁

@jhnns jhnns merged commit e766fb0 into peerigon:master Oct 3, 2018
@jhnns
Copy link
Member

jhnns commented Oct 3, 2018

Shipped with v3.0.0 🚀

@nathanchapman
Copy link
Contributor Author

Awesome, thanks Johannes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants