Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS error #955

Closed
strukturart opened this issue May 16, 2022 · 9 comments
Closed

CORS error #955

strukturart opened this issue May 16, 2022 · 9 comments
Labels
platform-specific issues affecting only specific platforms released on @rc released

Comments

@strukturart
Copy link

when trying to connect to the peerJS server I get the following error message:

ERROR PeerJS: Error retrieving ID (TypeError) 'referrerPolicy' member of RequestInit 'strict-origin-when-cross-origin' is not a valid value for enumeration ReferrerPolicy.

@franci2000
Copy link

Hey @strukturart,
thanks for your report!

Could you tell us:

  • which Browser are you using?
  • do you host the server yourself?
  • does the request fail or is it just a warning?

@strukturart
Copy link
Author

which Browser are you using?
KaiOs 2.5.1
do you host the server yourself?
no
does the request fail or is it just a warning?
request fail

@franci2000
Copy link

I’m sorry, but we probably won’t fix this if it’s not an issue with other - more common - browsers too.
With an estimated global usage of only 0.07%, KaiOS 2.5 is strictly out of scope for us. The browser engine was released almost 6 years ago!

If you need to support KaiOS 2.5, PeerJS v1.3 or below are still an option. They don’t use this policy.

@franci2000 franci2000 added platform-specific issues affecting only specific platforms wontfix verified, but won't be fixed labels May 16, 2022
@strukturart
Copy link
Author

Is the problem on the client side or on the server side? then I would adjust the version.

@franci2000
Copy link

Just the client.

github-actions bot pushed a commit that referenced this issue May 17, 2022
## [1.4.5-rc.1](v1.4.4...v1.4.5-rc.1) (2022-05-17)

### Bug Fixes

* **referrerPolicy:** you can now set a custom referrerPolicy for api requests ([c0ba9e4](c0ba9e4)), closes [#955](#955)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.4.5-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonasgloning
Copy link
Member

Hey @strukturart,

We discussed this further internally. KaiOS 2 is still not a target for us, but there might be value for everyone in customizing the referrer policy. I pushed a patch to the rc branch.

You can get it from npm i --save peerjs@rc, or eventually in the next release. Then just set your desired policy:

new Peer({
	referrerPolicy: 'origin-when-cross-origin',
})

@strukturart
Copy link
Author

Thank you!

@franci2000 franci2000 removed the wontfix verified, but won't be fixed label May 18, 2022
github-actions bot pushed a commit that referenced this issue May 24, 2022
## [1.4.5](v1.4.4...v1.4.5) (2022-05-24)

### Bug Fixes

* **referrerPolicy:** you can now set a custom referrerPolicy for api requests ([c0ba9e4](c0ba9e4)), closes [#955](#955)
* **typings:** add missing type exports ([#959](#959)) ([3c915d5](3c915d5)), closes [#961](#961)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-specific issues affecting only specific platforms released on @rc released
Projects
None yet
Development

No branches or pull requests

3 participants