peerjs.min.js compiled with a function $(...)

[whoisterencelee]

The dist/peerjs.min.js for some reason is compiled with a function $ which is global and gets into conflict with browser debugger's $ or any globally defined $

This causes this error whenever using $('someDOMselector') in site:

Uncaught TypeError: right-hand side of 'in' should be an object, got undefined``

Because it expect $(window) from this function, from webrtc-adapter dependency

export function shimGetDisplayMedia(window) {
  if (!('getDisplayMedia' in window.navigator)) {

[whoisterencelee]

A workaround is the replace
function $(...
with
function shim(

and

return $
with
return shim

in dist/peerjs.min.js

[create-issue-branch]

Branch issue-989-peerjs_min_js_compiled_with_a_function_$ created!

[jonasgloning]

Hey @whoisterencelee, thanks for the report!

The file is polluting the global namespace. This definitely shouldn’t happen.
A fix should be trivial: The output format of the bundler was set to the wrong environment.
But I want to ensure that the patch doesn’t break anything else, so there’s a bit more testing before release.

[github-actions]

🎉 This issue has been resolved in version 1.4.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀