Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _totalMinted Function #3

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Add _totalMinted Function #3

merged 2 commits into from
Feb 23, 2022

Conversation

ahbanavi
Copy link

@ahbanavi ahbanavi commented Feb 20, 2022

Add _totalMinted function, as discussed in chiru-labs#124

I add tests for these situations:

  • For both start token at 0 and 1
    • Before mint must return 0
    • After mint return correct value
  • For ERC721ABurnable
    • Burning must not affect return value.

Also, added a comment for totalSupply() to encourage using _totalMinted() instead (for checking minted counts).

@Vectorized
Copy link

@Pczek You there? :)

@peetzweg peetzweg merged commit 8618b66 into peetzweg:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants