Add validation of encryption key length and method #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, there is no validation of the encryption key length
and method, so if using an encryption method but with a not matched length
encryption key, it would cause encrypt and decrypt not match bug.
This patch fixes this bug and adds some related modifacations, including:
RegisterOptions
to initialize theAESEncryptionProvider
objectsinstead of
AddFactory
AddFactory
to createAESEncryptionProvider
objectsAddFactory
will only createAESEncryptionProvider
objects successfullywhen the uri match
AES
variables instead, say
TEST_FS_URI
andENCRYPTED_ENV
db_bench
tool, we can use--fs_uri
insteadencryption/encryption_test.cc
build-linux-encrypted_env-openssl*
The functionality can be checked by the following script as well.