Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Remove /pljava before cloning #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove /pljava before cloning #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ ENV TERM xterm-256color

RUN apt-get update && \
apt-get --fix-missing -y --force-yes --no-install-recommends install git ca-certificates && \
rm -rf /pljava && \
Copy link

@cdancy cdancy Sep 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this directory should not exist before the line just below where we clone. How is it you're hitting this issue if we haven't yet cloned the repo? Maybe a stale docker cache or you're doing things in a non-standard way?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got a clue. It could be stale docker cache. Not sure how to verify that. Nevertheless, this could be a good fail-save. If it happened to my build, it could happen to someone else's build.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind can you provide the build command you are using? You should be able to use the --no-cache option to skip docker using any cache and get around your problem.

The change in question is safe just should be unnecessary is all.

Copy link
Author

@MichelKraaij MichelKraaij Sep 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker build -t pega-database:8.3.0-225 .
I''ve tried running the above build command with --no-cache, but still get the same result.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is flipping weird and shouldn't be happening. I can't really explain how things could pop if the folder does not exist yet. The only thing that makes sense is something in the docker cache.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It shouldn't be happening. That folder shouldn't have been there in the first place. But I didn't create it manually. So it seems that it could be something that occurs (maybe even randomly) on machines. It's definitely weird.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this PR open for a little while longer to see if we magically stumble upon something but I'm under the current assumption that this shouldn't be needed.

git clone https://github.com/tada/pljava.git && \
apt-get --fix-missing -y --force-yes --no-install-recommends install g++ maven && \
apt-get --fix-missing -y --force-yes --no-install-recommends install postgresql-server-dev-11 libpq-dev && \
Expand Down