Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorized output when test is redirected #315

Closed
Tracked by #316
hildjj opened this issue Jul 18, 2022 · 0 comments · Fixed by #317
Closed
Tracked by #316

Colorized output when test is redirected #315

hildjj opened this issue Jul 18, 2022 · 0 comments · Fixed by #317
Assignees
@hildjj
Labels
blocks-release Blocks an imminent release. High Priorty.

Comments

@hildjj
Copy link
Contributor

hildjj commented Jul 18, 2022

This command:

bin/peggy.js src/parser.pegjs -T examples/fizzbuzz.peggy  > /tmp/p.js

writes colorized output to /tmp/p.js, because we're only checking to see if stderr is a TTY, not stdout.

Work-around:

bin/peggy.js src/parser.pegjs -T examples/fizzbuzz.peggy  > /tmp/p.js 2>&1
@hildjj hildjj self-assigned this Jul 18, 2022
@hildjj hildjj mentioned this issue Jul 20, 2022
Closed
23 tasks
@hildjj hildjj added the blocks-release Blocks an imminent release. High Priorty. label Jul 20, 2022
hildjj added a commit to hildjj/peggy that referenced this issue Jul 20, 2022
@hildjj
Fixes peggyjs#315. Check isTTY for all output before using colors.
b48a69f
@hildjj hildjj mentioned this issue Jul 20, 2022
Merged
hildjj added a commit to hildjj/peggy that referenced this issue Jul 20, 2022
@hildjj
Fixes peggyjs#315. Check isTTY for all output before using colors.
9397d96
hildjj added a commit to hildjj/peggy that referenced this issue Jul 20, 2022
@hildjj
Fixes peggyjs#315. Check isTTY for all output before using colors.
5f8e04c
hildjj added a commit to hildjj/peggy that referenced this issue Jul 20, 2022
@hildjj
Fixes peggyjs#315. Check isTTY for all output before using colors.
93f8d1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildjj hildjj

Labels
blocks-release Blocks an imminent release. High Priorty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check isTTY for all output before using colors. hildjj/peggy
1 participant
@hildjj