Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site CNAME removed on doc publish workflow #352

Closed
hildjj opened this issue Feb 24, 2023 · 3 comments
Closed

Site CNAME removed on doc publish workflow #352

hildjj opened this issue Feb 24, 2023 · 3 comments

Comments

@hildjj
Copy link
Contributor

hildjj commented Feb 24, 2023

After running the "Deploy to GitHub Pages" workflow, the site's custom domain is erased. I believe that the workflow needs to leave a file named CNAME in the root of the docs branch, containing the string "peggyjs.org" with no newline.

When I fix the issue in the website, that's the diff that github applies to the docs branch.

Assigned: @camchenry

@hildjj
Copy link
Contributor Author

hildjj commented Feb 24, 2023

When fixing, please base the PR on the feature-docs branch, then I'll pull that into both stable and main.

@camchenry
Copy link
Contributor

@hildjj We should be able to fix this by telling the 11ty compiler to copy the CNAME file to the output directory when compiling the website. It should be doable by just adding another line here:

https://github.com/peggyjs/peggy/blob/main/docs/.eleventy.js#L2-L7

Like so:

eleventyConfig.addPassthroughCopy("CNAME");

@hildjj
Copy link
Contributor Author

hildjj commented Feb 24, 2023

On it.

hildjj added a commit that referenced this issue Feb 24, 2023
@hildjj hildjj closed this as completed in 9594662 Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants