Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated code has wrong version number #72

Closed
GreenImp opened this issue Apr 18, 2021 · 2 comments · Fixed by #84
Closed

Generated code has wrong version number #72

GreenImp opened this issue Apr 18, 2021 · 2 comments · Fixed by #84

Comments

@GreenImp
Copy link

GreenImp commented Apr 18, 2021 •
edited
Loading

I have noticed that the Peggy version number in the generated output is incorrect. It says;

// Generated by Peggy 0.11.0.
//
// https://github.com/peggyjs/peggy

Whereas I presume it should be:

// Generated by Peggy 1.0.0
//
// https://github.com/peggyjs/peggy
hildjj added a commit to hildjj/peggy that referenced this issue Apr 18, 2021
@hildjj
Fixes peggyjs#72
f902906
@hildjj
Copy link
Contributor

hildjj commented Apr 18, 2021

Good catch. This is fixed in the monorepo branch, which will drop as soon as i've got reviews.

@hildjj hildjj closed this as completed Apr 18, 2021
@hildjj hildjj reopened this Apr 18, 2021
hildjj added a commit to hildjj/peggy that referenced this issue Apr 19, 2021
@hildjj
Fixes peggyjs#72. Use correct version information and correct URL in …
b3e957e 
…generated code
@hildjj hildjj mentioned this issue Apr 19, 2021
Merged
@hildjj
Copy link
Contributor

hildjj commented Apr 19, 2021

Since it doesn't look like we're going to merge the monorepo patch, I created a separate PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct version information and correct URL hildjj/peggy
2 participants
@hildjj @GreenImp