Add source-with-inline-map #282
Conversation
docs/documentation.html
Outdated
| <code>"source-with-inline-map"</code>. The path should be relative to | ||
| the location where the generated parser code will be stored.</p> |
There was a problem hiding this comment.
The last sentence seems not relevant for source-with-inline-map
There was a problem hiding this comment.
I think it is, actually. If you generate with grammar source "src/foo.peggy", and write the output file to "lib/foo.peggy", then the grammar source needs to be "../src/foo.peggy". On the CLI, you can use fully-qualified paths, because i use node's path.relative to fix them up. Here, I don't want to pull in path or a polyfill, so I just change the requirement so that the grammarSource has to be relative.
There was a problem hiding this comment.
Never-mind, my mistake. I mistakenly thought that it is the path to the file into which the source map is embed, that is why I was doubt is it required to have a concrete value at all.
However, perhaps add your example to the doc?
There was a problem hiding this comment.
An example is a great idea. Adding.
lib/peg.d.ts
Outdated
| * Note, that `SourceNode.source`s of the generated source map will depend | ||
| * on the `options.grammarSource` value. Therefore, value `options.grammarSource` | ||
| * will propagate to the `sources` array of the source map. That array MUST | ||
| * contain a path relative to the source map location, as no further path | ||
| * processing will be performed. |
There was a problem hiding this comment.
That part seems incorrect. What location the inline source map have?
There was a problem hiding this comment.
This needs to be worded better. The important point is that the grammarSource is a string with a path relative to where the .js file will eventually be written.
test/unit/compiler.spec.js
Outdated
|
|
||
| it("generates inline sourceMappingURL", () => { | ||
| const ast = parser.parse("foo='1'"); | ||
| // Ensure there is an expect even if we don't run the good tests below. |
There was a problem hiding this comment.
| // Ensure there is an expect even if we don't run the good tests below. | |
| // Ensure there is an object even if we don't run the good tests below. |
Misprint, I guess
There was a problem hiding this comment.
eh, i'll just remove the comment. what i'm aiming for is that if you're running in an old browser, you don't see an error, and the it contains at least one expect.
|
Fixed two doc issues, added changelog, and fixed #283 while I was in there. |
Co-authored-by: Mingun <Alexander_Sergey@mail.ru>
hildjj
force-pushed
the
source-with-inline-map
branch
from
1a3e05b to
b9f5e85
Compare
|
I'll rebase to squash the extra commits before landing. Left them separate so you could see the changes for now. |
hildjj
force-pushed
the
source-with-inline-map
branch
from
b9f5e85 to
e879502
Compare
Fixes #280.