Handle large outputs from exec. #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hildjj
force-pushed
the
mock-stream-buffering
branch
from
a8f96d9 to
766c6a8
Compare
Mingun
reviewed
Jun 11, 2022
test/cli/run.spec.ts
Outdated
| @@ -186,7 +189,14 @@ async function exec(opts: Options = {}) { | |||
| } | |||
|
|
|||
| if (outputString === null) { | |||
There was a problem hiding this comment.
This check is still always true, because outputString doesn't change after declaring at line 126
Mingun
approved these changes
Jun 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287.
@Mingun, please rebase #206 on this, and see if it fixes your problem before I merge.